[coreboot-gerrit] Change in coreboot[master]: intel/i945: Fix booting on a dual channel configuration

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Nov 16 18:02:34 CET 2018


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29663


Change subject: intel/i945: Fix booting on a dual channel configuration
......................................................................

intel/i945: Fix booting on a dual channel configuration

The register values in dram width programming changed in
commit a4fc7bef7ffab0 which broke booting on getac/p470.

TEST=getac/p470 with 2 X8DDS DRAM boots again

Change-Id: I8b3eedc8c5234e8a28948d4dc58bf565024f62ce
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/29663/1

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index 30e16db..5f06b7d 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -660,13 +660,13 @@
 			c1dramw |= (0x0000) << 4*(i % 2);
 			break;
 		case SYSINFO_DIMM_X8DS:
-			c1dramw |= (0x0001) << 4*(i % 2);
+			c1dramw |= (0x0010) << 4*(i % 2);
 			break;
 		case SYSINFO_DIMM_X16SS:
 			c1dramw |= (0x0000) << 4*(i % 2);
 			break;
 		case SYSINFO_DIMM_X8DDS:
-			c1dramw |= (0x0005) << 4*(i % 2);
+			c1dramw |= (0x0050) << 4*(i % 2);
 			break;
 		case SYSINFO_DIMM_NOT_POPULATED:
 			c1dramw |= (0x0000) << 4*(i % 2);

-- 
To view, visit https://review.coreboot.org/29663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b3eedc8c5234e8a28948d4dc58bf565024f62ce
Gerrit-Change-Number: 29663
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181116/f2059d60/attachment.html>


More information about the coreboot-gerrit mailing list