[coreboot-gerrit] Change in coreboot[master]: util/cbsftool: allow enabling verbose make output

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Nov 16 13:59:12 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29431 )

Change subject: util/cbsftool: allow enabling verbose make output
......................................................................

util/cbsftool: allow enabling verbose make output

Sometimes it is necessary to be able to see exact command lines used
when compiling and linking. Use the same scheme as some other
Makefile's - enable verbose output when variable V is set to 1.

TEST=tried building cbfstool with V=1, observed verbose output.

Change-Id: Iff25439aabff79e69d1d94a2c51c60bb0e0d7b80
Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
Reviewed-on: https://review.coreboot.org/29431
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M util/cbfstool/Makefile
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile
index ba8fdff..f4dca3f 100644
--- a/util/cbfstool/Makefile
+++ b/util/cbfstool/Makefile
@@ -51,6 +51,8 @@
 	$(INSTALL) ifwitool $(DESTDIR)$(BINDIR)
 	$(INSTALL) cbfs-compression-tool $(DESTDIR)$(BINDIR)
 
+ifneq ($(V),1)
 .SILENT:
+endif
 
 include Makefile.inc

-- 
To view, visit https://review.coreboot.org/29431
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff25439aabff79e69d1d94a2c51c60bb0e0d7b80
Gerrit-Change-Number: 29431
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181116/ac3005b8/attachment.html>


More information about the coreboot-gerrit mailing list