[coreboot-gerrit] Change in coreboot[master]: mb/lenovo: Unify thermal threshold handling

Peter Lemenkov (Code Review) gerrit at coreboot.org
Fri Nov 16 13:44:19 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/29659

to look at the new patch set (#3).

Change subject: mb/lenovo: Unify thermal threshold handling
......................................................................

mb/lenovo: Unify thermal threshold handling

Unify thermal handling across Lenovo boards. Namely, do the following:

* Move thermal levels from acpi_tables to thermal.h (and create if
  necessary).
* Don't use board-specific ifdef guards.
* Set thermal levels using dedicated acpi_update_thermal_table function
  as almost all Lenovo boards do.
* Update list of authors in comments. Merge all author's entries.
* Minor whitespace and formatting.

This makes diff -ruw between the Lenovo borders smaller.

Change-Id: If569f67c932b7fbf14893b890a5588df4994daeb
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
M src/mainboard/lenovo/l520/acpi_tables.c
M src/mainboard/lenovo/l520/thermal.h
M src/mainboard/lenovo/s230u/acpi_tables.c
A src/mainboard/lenovo/s230u/thermal.h
M src/mainboard/lenovo/t400/acpi_tables.c
A src/mainboard/lenovo/t400/thermal.h
M src/mainboard/lenovo/t420/thermal.h
M src/mainboard/lenovo/t420s/thermal.h
M src/mainboard/lenovo/t430/thermal.h
M src/mainboard/lenovo/t430s/thermal.h
M src/mainboard/lenovo/t520/acpi_tables.c
M src/mainboard/lenovo/t520/thermal.h
M src/mainboard/lenovo/t530/acpi_tables.c
M src/mainboard/lenovo/t530/thermal.h
M src/mainboard/lenovo/t60/acpi_tables.c
A src/mainboard/lenovo/t60/thermal.h
M src/mainboard/lenovo/x131e/thermal.h
M src/mainboard/lenovo/x1_carbon_gen1/thermal.h
M src/mainboard/lenovo/x200/acpi_tables.c
A src/mainboard/lenovo/x200/thermal.h
M src/mainboard/lenovo/x201/acpi_tables.c
A src/mainboard/lenovo/x201/thermal.h
M src/mainboard/lenovo/x220/thermal.h
M src/mainboard/lenovo/x230/thermal.h
M src/mainboard/lenovo/x60/acpi_tables.c
A src/mainboard/lenovo/x60/thermal.h
M src/mainboard/lenovo/z61t/acpi_tables.c
A src/mainboard/lenovo/z61t/thermal.h
28 files changed, 402 insertions(+), 115 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/29659/3
-- 
To view, visit https://review.coreboot.org/29659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If569f67c932b7fbf14893b890a5588df4994daeb
Gerrit-Change-Number: 29659
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181116/faacd3bc/attachment.html>


More information about the coreboot-gerrit mailing list