[coreboot-gerrit] Change in coreboot[master]: tss: implement Cr50 vendor-specific VENDOR_CC_TPM_MODE

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Nov 16 07:32:10 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29648 )

Change subject: tss: implement Cr50 vendor-specific VENDOR_CC_TPM_MODE
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/29648/4/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:

https://review.coreboot.org/#/c/29648/4/src/security/tpm/tss/tcg-2.0/tss_marshaling.c@482
PS4, Line 482: 		break;
break is not useful after a goto or return



-- 
To view, visit https://review.coreboot.org/29648
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd55708797d2b17336fcbe80c0724957f7052e90
Gerrit-Change-Number: 29648
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte at chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Comment-Date: Fri, 16 Nov 2018 06:32:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181116/04674983/attachment.html>


More information about the coreboot-gerrit mailing list