[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Invert FP MCU wake signal

Shelley Chen (Code Review) gerrit at coreboot.org
Fri Nov 16 01:15:33 CET 2018


Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/29650


Change subject: mb/google/poppy/variants/nami: Invert FP MCU wake signal
......................................................................

mb/google/poppy/variants/nami: Invert FP MCU wake signal

GPP_D6 needs to be inverted to enter S0ix.  Keeps device awake
otherwise.

BUG=b:119447525, b:115706071
BRANCH=Nami
TEST=Run powerd_dbus_suspend from kernel and make sure see DUT drop into
     S0ix in the EC console.

Change-Id: Iad5df124e2439bbdc078d6a33f8d0510d25ecf6f
Signed-off-by: Shelley Chen <shchen at google.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/29650/1

diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 6b8b650..f48033a 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -426,7 +426,7 @@
 	/* D5  : ISH_I2C0_SDA ==> FPMCU_BOOT0 */
 	PAD_CFG_GPO(GPP_D5, 0, DEEP),
 	/* D6  : ISH_I2C0_SCL ==> FPMCU_INT_L */
-	PAD_CFG_GPI_IRQ_WAKE(GPP_D6, 20K_PU, DEEP, LEVEL, NONE),
+	PAD_CFG_GPI_IRQ_WAKE(GPP_D6, 20K_PU, DEEP, LEVEL, INVERT),
 	/* D17 : DMIC_CLK1 ==> NC */
 	PAD_CFG_NC(GPP_D17),
 };

-- 
To view, visit https://review.coreboot.org/29650
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad5df124e2439bbdc078d6a33f8d0510d25ecf6f
Gerrit-Change-Number: 29650
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181116/1ce6cdb7/attachment.html>


More information about the coreboot-gerrit mailing list