[coreboot-gerrit] Change in coreboot[master]: SMBIOS: Remove duplicated smbios_memory_type enum

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29638 )

Change subject: SMBIOS: Remove duplicated smbios_memory_type enum
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/29638/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29638/2//COMMIT_MSG@9
PS2, Line 9: memory_speed
I would prefer mem_clock_frequency or mem_clk_freq. Something that clearly says memory clock frequency. clock_frequency would be acceptable too. Unless this defines transfer rate instead of clock (DDR has 2 transfers per clock cycle for example). Only then would memory_speed be acceptable.


https://review.coreboot.org/#/c/29638/2/src/include/smbios.h
File src/include/smbios.h:

https://review.coreboot.org/#/c/29638/2/src/include/smbios.h@a122
PS2, Line 122: 
             : 
             : 
             : 
             : 
             : 
These memory types are not present at smbios_memory_type enum. They need to go there (renamed).



-- 
To view, visit https://review.coreboot.org/29638
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49554d13f1b6371b85a58cc1263608ad9e99130e
Gerrit-Change-Number: 29638
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 14 Nov 2018 17:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181114/3ca55ec9/attachment.html>