[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Reset Pre-OP after atomic SPI cycle is finished

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/29634


Change subject: sb/intel/common: Reset Pre-OP after atomic SPI cycle is finished
......................................................................

sb/intel/common: Reset Pre-OP after atomic SPI cycle is finished

Make sure that the Pre-Op register is cleared when an atomic cycle has
been finished without errors.

Change-Id: Ied88337125b125474b411e2f39f668171d15bfac
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/southbridge/intel/common/spi.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/29634/1

diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c
index 31cdb33..0aa3970 100644
--- a/src/southbridge/intel/common/spi.c
+++ b/src/southbridge/intel/common/spi.c
@@ -2,6 +2,7 @@
  * Copyright (c) 2011 The Chromium OS Authors.
  * Copyright (C) 2009, 2010 Carl-Daniel Hailfinger
  * Copyright (C) 2011 Stefan Tauner
+ * Copyright (C) 2018 Siemens AG
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
@@ -610,7 +611,7 @@
 			return -1;
 		}
 
-		return 0;
+		goto spi_xfer_exit;
 	}
 
 	/*
@@ -675,6 +676,7 @@
 		}
 	}
 
+spi_xfer_exit:
 	/* Clear atomic preop now that xfer is done */
 	writew_(0, cntlr->preop);
 

-- 
To view, visit https://review.coreboot.org/29634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied88337125b125474b411e2f39f668171d15bfac
Gerrit-Change-Number: 29634
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181114/a6973281/attachment.html>