[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29631 )

Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants/nautilus/smihandler.c
File src/mainboard/google/poppy/variants/nautilus/smihandler.c:

https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants/nautilus/smihandler.c@29
PS2, Line 29:           
trailing whitespace


https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants/nautilus/smihandler.c@29
PS2, Line 29:           
code indent should use tabs where possible


https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants/nautilus/smihandler.c@29
PS2, Line 29:           
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/29631
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134
Gerrit-Change-Number: 29631
Gerrit-PatchSet: 2
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 14 Nov 2018 02:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181114/6ac920e8/attachment.html>