[coreboot-gerrit] Change in coreboot[master]: azalia: Add Azalia Reset macro

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Nov 13 23:56:11 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29554 )

Change subject: azalia: Add Azalia Reset macro
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/29554/8/src/include/device/azalia_device.h
File src/include/device/azalia_device.h:

https://review.coreboot.org/#/c/29554/8/src/include/device/azalia_device.h@50
PS8, Line 50: #define AZALIA_RESET(pin)					\
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/29554
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie788b7153e25b764cd1d33753af17d5ed4903c36
Gerrit-Change-Number: 29554
Gerrit-PatchSet: 8
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181113/cd9870de/attachment.html>


More information about the coreboot-gerrit mailing list