[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )

Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x1/overridetree.cb
File src/mainboard/lenovo/x220/variants/x1/overridetree.cb:

https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x1/overridetree.cb@17
PS8, Line 17: 			subsystemid 0x17aa 0x21e8
there's no reason to override the subsystemid.
It's 0x17aa for lenovo, that should be sufficient...



-- 
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 13 Nov 2018 14:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181113/c37193b8/attachment.html>