[coreboot-gerrit] Change in coreboot[master]: (console, drivers/uart)/Kconfig: Fix dependencies

Nico Huber (Code Review) gerrit at coreboot.org
Mon Nov 12 20:14:59 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/29572

to look at the new patch set (#2).

Change subject: (console,drivers/uart)/Kconfig: Fix dependencies
......................................................................

(console,drivers/uart)/Kconfig: Fix dependencies

The dependencies of CONSOLE_SERIAL and DRIVERS_UART were somehow
backwards. Fix that. Now, CONSOLE_SERIAL depends on DRIVERS_UART,
because it's using its interface. The individual UART drivers
select DRIVERS_UART, because they implement the interface and
depend on the common UART code.

Some guards had to be fixed (using CONSOLE_SERIAL now instead of
DRIVERS_UART). Some other guards that were only about compilation
of units were removed. We want to build test as much as possible,
right?

Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/console/Kconfig
M src/cpu/allwinner/a10/Makefile.inc
M src/cpu/ti/am335x/Makefile.inc
M src/drivers/uart/Kconfig
M src/mainboard/google/gru/bootblock.c
M src/mainboard/google/veyron/bootblock.c
M src/mainboard/google/veyron_mickey/bootblock.c
M src/mainboard/google/veyron_rialto/bootblock.c
M src/soc/broadcom/cygnus/Makefile.inc
M src/soc/imgtec/pistachio/Makefile.inc
M src/soc/mediatek/mt8173/Makefile.inc
M src/soc/mediatek/mt8183/Makefile.inc
M src/soc/nvidia/tegra124/Makefile.inc
M src/soc/nvidia/tegra210/Makefile.inc
M src/soc/qualcomm/ipq40xx/Makefile.inc
M src/soc/qualcomm/ipq40xx/uart.c
M src/soc/qualcomm/ipq806x/Makefile.inc
M src/soc/qualcomm/ipq806x/uart.c
M src/soc/qualcomm/sdm845/Makefile.inc
M src/soc/rockchip/rk3288/Makefile.inc
M src/soc/rockchip/rk3399/Makefile.inc
M src/soc/samsung/exynos5250/Makefile.inc
22 files changed, 58 insertions(+), 89 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/29572/2
-- 
To view, visit https://review.coreboot.org/29572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9
Gerrit-Change-Number: 29572
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181112/bc8f8369/attachment.html>


More information about the coreboot-gerrit mailing list