[coreboot-gerrit] Change in coreboot[master]: util/scripts/maintainers.go: Provide delimiters between maintainers

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Nov 12 17:54:22 CET 2018


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29604


Change subject: util/scripts/maintainers.go: Provide delimiters between maintainers
......................................................................

util/scripts/maintainers.go: Provide delimiters between maintainers

Help automated tools make sense of the output.
Instead of "[name 1 <email> name 2 <email>]", it now prints
"name 1 <email>, name 2 <email>". As long as there are no commas in the
maintainer names, they can be split easily.

Change-Id: I4a254f566404b081a08923bc7ceb49f02039aa2a
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/scripts/maintainers.go
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29604/1

diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go
index f99dc37..901817a 100644
--- a/util/scripts/maintainers.go
+++ b/util/scripts/maintainers.go
@@ -19,6 +19,7 @@
 	"log"
 	"os"
 	"os/exec"
+	"strings"
 
 	"github.com/gobwas/glob"
 )
@@ -172,7 +173,7 @@
 			success = true
 			fmt.Println(fname, "is in subsystem",
 				subsystem.name)
-			fmt.Println("Maintainers: ", subsystem.maintainer)
+			fmt.Println("Maintainers: ", strings.Join(subsystem.maintainer, ", "))
 		}
 	}
 	if !success {

-- 
To view, visit https://review.coreboot.org/29604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a254f566404b081a08923bc7ceb49f02039aa2a
Gerrit-Change-Number: 29604
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181112/dedf2ca3/attachment.html>


More information about the coreboot-gerrit mailing list