[coreboot-gerrit] Change in coreboot[master]: security/tpm: Fix TCPA log feature

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Nov 12 13:42:15 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29563 )

Change subject: security/tpm: Fix TCPA log feature
......................................................................


Patch Set 13:

(2 comments)

https://review.coreboot.org/#/c/29563/13/src/include/memlayout.h
File src/include/memlayout.h:

https://review.coreboot.org/#/c/29563/13/src/include/memlayout.h@168
PS13, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
Macros with multiple statements should be enclosed in a do - while loop


https://review.coreboot.org/#/c/29563/13/src/include/memlayout.h@168
PS13, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
macros should not use a trailing semicolon



-- 
To view, visit https://review.coreboot.org/29563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44
Gerrit-Change-Number: 29563
Gerrit-PatchSet: 13
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph (1001864)
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 12 Nov 2018 12:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181112/0b70f452/attachment.html>


More information about the coreboot-gerrit mailing list