[coreboot-gerrit] Change in coreboot[master]: lenovo/h8, thinkpads: Re-do USB Always On

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29565 )

Change subject: lenovo/h8,thinkpads: Re-do USB Always On
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c
File src/ec/lenovo/h8/h8.c:

https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@136
PS4, Line 136: bits
Pointless comment. It's clear from code below


https://review.coreboot.org/#/c/29565/4/src/ec/lenovo/h8/h8.c@141
PS4, Line 141: ;
Please don't use magic values



-- 
To view, visit https://review.coreboot.org/29565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a
Gerrit-Change-Number: 29565
Gerrit-PatchSet: 4
Gerrit-Owner: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 10 Nov 2018 22:29:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181110/276c4c95/attachment.html>