[coreboot-gerrit] Change in coreboot[master]: arch/acpi.h: Add FACS – ospm flags

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sat Nov 10 20:50:02 CET 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29569


Change subject: arch/acpi.h: Add FACS – ospm_flags
......................................................................

arch/acpi.h: Add FACS – ospm_flags

regarding ACPI Version 6.2 Errata A, 64BIT_WAKE_F
flag can only be set if platform firmware sets
64BIT_WAKE_SUPPORTED_F in the FACS flags field.

Change-Id: I91291c8202d1562b720b9922791c6282e572601f
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/arch/x86/include/arch/acpi.h
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29569/1

diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h
index b5205c0..b5fac2f 100644
--- a/src/arch/x86/include/arch/acpi.h
+++ b/src/arch/x86/include/arch/acpi.h
@@ -600,8 +600,10 @@
 	u32 flags;				/* FACS flags */
 	u32 x_firmware_waking_vector_l;		/* X FW waking vector, low */
 	u32 x_firmware_waking_vector_h;		/* X FW waking vector, high */
-	u8 version;				/* ACPI 4.0: 2 */
-	u8 resv[31];				/* FIXME: 4.0: ospm_flags */
+	u8 version;				/* ACPI 6.2-A: 2 */
+	u8 resv[3];				/* ACPI 6.2-A: 0 */
+	u8 ospm_flags;				/* 64BIT_WAKE_F */
+	u8 resv[24];				/* ACPI 6.2-A: 0 */
 } __packed acpi_facs_t;
 
 /* FACS flags */

-- 
To view, visit https://review.coreboot.org/29569
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91291c8202d1562b720b9922791c6282e572601f
Gerrit-Change-Number: 29569
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181110/dfc5770d/attachment.html>


More information about the coreboot-gerrit mailing list