[coreboot-gerrit] Change in coreboot[master]: cpu/intel/speedstep: Add Netburst CPUs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 )

Change subject: cpu/intel/speedstep: Add Netburst CPUs
......................................................................


Patch Set 38:

(4 comments)

https://review.coreboot.org/#/c/22604/38/src/cpu/intel/common/fsb.c
File src/cpu/intel/common/fsb.c:

https://review.coreboot.org/#/c/22604/38/src/cpu/intel/common/fsb.c@48
PS38, Line 48: 	case 0xf: /* Netburst */
Possible switch case/default not preceded by break or fallthrough comment


https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c
File src/cpu/intel/speedstep/speedstep.c:

https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c@38
PS38, Line 38: 		((c.x86 == 6 && c.x86_model == 0x17) ? SPEEDSTEP_RATIO_NONINT : 0)
line over 80 characters


https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c@110
PS38, Line 110:                 }
code indent should use tabs where possible


https://review.coreboot.org/#/c/22604/38/src/cpu/intel/speedstep/speedstep.c@110
PS38, Line 110:                 }
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/22604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a
Gerrit-Change-Number: 22604
Gerrit-PatchSet: 38
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Sat, 10 Nov 2018 10:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181110/6642c0ee/attachment.html>