[coreboot-gerrit] Change in coreboot[master]: security/tpm: Fix TCPA log feature

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29563 )

Change subject: security/tpm: Fix TCPA log feature
......................................................................


Patch Set 1:

(9 comments)

https://review.coreboot.org/#/c/29563/1/src/arch/x86/car.ld
File src/arch/x86/car.ld:

https://review.coreboot.org/#/c/29563/1/src/arch/x86/car.ld@35
PS1, Line 35: 	 * Needs to be transfered until CBMEM is available
'transfered' may be misspelled - perhaps 'transferred'?


https://review.coreboot.org/#/c/29563/1/src/include/memlayout.h
File src/include/memlayout.h:

https://review.coreboot.org/#/c/29563/1/src/include/memlayout.h@168
PS1, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
Macros with multiple statements should be enclosed in a do - while loop


https://review.coreboot.org/#/c/29563/1/src/include/memlayout.h@168
PS1, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
macros should not use a trailing semicolon


https://review.coreboot.org/#/c/29563/1/src/security/tpm/tspi/log.c
File src/security/tpm/tspi/log.c:

https://review.coreboot.org/#/c/29563/1/src/security/tpm/tspi/log.c@31
PS1, Line 31: 		tclt = (struct tcpa_table*)_vboot2_tpm_log;
"(foo*)" should be "(foo *)"


https://review.coreboot.org/#/c/29563/1/src/security/tpm/tspi/log.c@70
PS1, Line 70: 				snprintf((char *)&(hash[j * 2]), tce->digest_length, "%02x", tce->digest[j]);
line over 80 characters


https://review.coreboot.org/#/c/29563/1/src/security/tpm/tspi/log.c@72
PS1, Line 72: 			snprintf(log_string, TCPA_LOG_STRING_LENGTH, " %u %s 00 [%s]\n",
line over 80 characters


https://review.coreboot.org/#/c/29563/1/src/security/vboot/vboot_crtm.c
File src/security/vboot/vboot_crtm.c:

https://review.coreboot.org/#/c/29563/1/src/security/vboot/vboot_crtm.c@162
PS1, Line 162: 	const struct tcpa_table *tclt = (struct tcpa_table*)_vboot2_tpm_log;
"(foo*)" should be "(foo *)"


https://review.coreboot.org/#/c/29563/1/src/security/vboot/vboot_crtm.c@165
PS1, Line 165: 		for (i = 0; i < tclt->num_entries; i++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/29563/1/src/security/vboot/vboot_crtm.c@166
PS1, Line 166: 			tcpa_log_add_table_entry(tclt->entries[i].name, tclt->entries[i].pcr, tclt->entries[i].digest, tclt->entries[i].digest_length);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44
Gerrit-Change-Number: 29563
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 23:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181109/99ebb06b/attachment.html>