[coreboot-gerrit] Change in coreboot[master]: arch/x86/smbios: [WIP] Add CPU SOCKET TYPE

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29529 )

Change subject: arch/x86/smbios: [WIP] Add CPU_SOCKET_TYPE
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> > Over all looks ok, but I would like analysis on the impact on
>  > SMBIOS tools.
> 
> I've used bits-2079 (BIOS Implementation Test Suite) on LGA775,
> it displays the right socket.
> 
> (still missing, the voltage, frequency, ... , but this is not related to current topic)

I'll wait to early next week, to give a chance to Raul or Martin to review it in face of a Google app (Mosis). I want their input before approving.


-- 
To view, visit https://review.coreboot.org/29529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf5ac6c411720d349df8fd706015c6835758cd0
Gerrit-Change-Number: 29529
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 14:50:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181109/8b3b4f13/attachment.html>