[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz

[Gaggery Tsai (Code Review)]

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/29553 )

Change subject: mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/29553/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29553/1//COMMIT_MSG@15
PS1, Line 15: Data Hold_time larger than 260ns (32 * 8.3ns = 265ns)
It shouldn't be 260ns. According to Grant, it should be 0ns for fast plus mode, please double check. Otherwise, the setting now is 20 --> 20*8.3 would less than 265ns.


https://review.coreboot.org/#/c/29553/1//COMMIT_MSG@34
PS1, Line 34: Verified by gaggery.tsai at intel.corp-partner.google.com.
            : See b/78601949 comment #177 (and many comments up to this one)
            : 
            : Verified by grundler at chromium.org.
            : See b/78601949 comment #155, #100, et al.
Do we need this in comment?



-- 
To view, visit https://review.coreboot.org/29553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf42ba7b8818b7cd9c8dcc657823dac705659d38
Gerrit-Change-Number: 29553
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
Gerrit-Comment-Date: Fri, 09 Nov 2018 05:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181109/f2d6d917/attachment.html>