[coreboot-gerrit] Change in coreboot[master]: mb/google/sarien: Program HD Audio SVID/SSID

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Nov 9 00:39:01 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29492 )

Change subject: mb/google/sarien: Program HD Audio SVID/SSID
......................................................................


Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/29492/6/src/mainboard/google/sarien/variants/arcada/include/variant/ssid.h
File src/mainboard/google/sarien/variants/arcada/include/variant/ssid.h:

https://review.coreboot.org/#/c/29492/6/src/mainboard/google/sarien/variants/arcada/include/variant/ssid.h@25
PS6, Line 25: 	{{{PCI_SUBSYSTEM_VENDOR_ID, HDA_FUNC, PCH_DEV_SLOT_LPC, 0, 0, 0, 0 }},
space required after that close brace '}'


https://review.coreboot.org/#/c/29492/6/src/mainboard/google/sarien/variants/sarien/include/variant/ssid.h
File src/mainboard/google/sarien/variants/sarien/include/variant/ssid.h:

https://review.coreboot.org/#/c/29492/6/src/mainboard/google/sarien/variants/sarien/include/variant/ssid.h@25
PS6, Line 25: 	{{{PCI_SUBSYSTEM_VENDOR_ID, HDA_FUNC, PCH_DEV_SLOT_LPC, 0, 0, 0, 0 }},
space required after that close brace '}'



-- 
To view, visit https://review.coreboot.org/29492
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c08da2daf8539864ea3f9aa04ccf488e2844da5
Gerrit-Change-Number: 29492
Gerrit-PatchSet: 6
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181108/25748b12/attachment.html>


More information about the coreboot-gerrit mailing list