[coreboot-gerrit] Change in coreboot[master]: [WIP]mb/opencellular/elgon: Enable write protection

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29532 )

Change subject: [WIP]mb/opencellular/elgon: Enable write protection
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29532/1/src/mainboard/opencellular/elgon/bootblock.c
File src/mainboard/opencellular/elgon/bootblock.c:

https://review.coreboot.org/#/c/29532/1/src/mainboard/opencellular/elgon/bootblock.c@73
PS1, Line 73: 	u8 reg8 = 0;
Why another check before spi_flash_is_write_protected() ?



-- 
To view, visit https://review.coreboot.org/29532
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a940c69ecb1dfd9704b2101c263570bebc5540e
Gerrit-Change-Number: 29532
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Nov 2018 12:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181108/b0dc13e7/attachment.html>