[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Call EC _PTS/_WAK methods if defined

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/29487 )

Change subject: soc/intel/common: Call EC _PTS/_WAK methods if defined
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > Looks like condrefof only works for the If statement and trying to actually call the method, even if it will not reach that code, causes the ASL compiler to fail.
> > 
> > I guess I will need to guard with a Kconfig option.
> 
> Aah yes. Does adding an External help:
> External (\_SB.PCI0.LPCB.EC0.WAK, MethodObj)
> External (\_SB.PCI0.LPCB.EC0.PTS, MethodObj)

Yeah this works, but I was concerned it would have issues at the OS level if these methods didn't actually exist.  I did some testing and it seems to be ok.


-- 
To view, visit https://review.coreboot.org/29487
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10
Gerrit-Change-Number: 29487
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 07 Nov 2018 18:21:37 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181107/0bbb514d/attachment.html>