[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29429 )

Change subject: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@138
PS2, Line 138: PLTRST
> Not sure how to reconcile the behavior in that case to ensure it doesn't have issues.

Yeah, especially if we end up using the same pin for APIC(interrupts) and SCI(wake), we cannot use PLTRST. Would that always result in interrupt storms? Or is it just specific to this device and kernel driver and hence resulting in a storm.



-- 
To view, visit https://review.coreboot.org/29429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc
Gerrit-Change-Number: 29429
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 06 Nov 2018 22:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/74f64ea6/attachment.html>