[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/29429 )

Change subject: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@138
PS2, Line 138: PLTRST
> Any update on this?
I had read in another CL yesterday (that I'm having trouble finding again to include here, sorry) that interrupts using GPI_APIC needed to use PLTRST to assure status gets reset properly across S3, which does match the behavior we were seeing when set to DEEP.  Are you aware of this requirement / was the comment I read correct?  I noticed that seems to hold true in a lot of other board's files, most use PLTRST with PAD_CFG_GPI_APIC(), although there are some poppy outliers (atlas, rammus, and nautilus).  Do those boards use S3?  I see that the SAR sensor GPIOs defined in this file need this change as well.  We're not using the SAR sensors on nocturne right now, which is likely why it hasn't shown up as an issue.  I'll fix that in a separate CL.



-- 
To view, visit https://review.coreboot.org/29429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc
Gerrit-Change-Number: 29429
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:46:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/bbd0e838/attachment.html>