[coreboot-gerrit] Change in coreboot[master]: payloads/external/Linuxboot/targets: fix Makefile output of u-root

Jens Drenhaus (Code Review) gerrit at coreboot.org
Tue Nov 6 16:47:24 CET 2018


Jens Drenhaus has uploaded this change for review. ( https://review.coreboot.org/29514


Change subject: payloads/external/Linuxboot/targets: fix Makefile output of u-root
......................................................................

payloads/external/Linuxboot/targets: fix Makefile output of u-root

suppress printing echo commandlines and split long output in
multiple lines.

Change-Id: Ic63a8f498720fda6d4ac3e287572dbf76500adfa
Signed-off-by: Jens Drenhaus <jens.drenhaus at 9elements.com>
---
M payloads/external/LinuxBoot/targets/u-root.mk
1 file changed, 13 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/29514/1

diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk
index 27f184e..d4a0837 100644
--- a/payloads/external/LinuxBoot/targets/u-root.mk
+++ b/payloads/external/LinuxBoot/targets/u-root.mk
@@ -39,7 +39,7 @@
 	mkdir -p $(project_dir)/go/src/github.com/u-root
 
 $(uroot_dir)/.git:
-	echo "    Git        Cloning u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)"
+	@echo "    Git        Cloning u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)"
 	git clone $(uroot_git_repo) $(uroot_dir)
 
 fetch: check $(uroot_dir)/.git
@@ -63,27 +63,32 @@
 	fi
 
 $(uroot_dir)/u-root: $(uroot_dir)/u-root.go
-	echo "    GO        u-root"
-	cd $(uroot_dir); GOPATH=$(go_path_dir) go build u-root.go
+	@echo "    GO        u-root"
+	cd $(uroot_dir); \
+	GOPATH=$(go_path_dir) go build u-root.go
 
 $(project_dir)/initramfs.cpio.xz: checkout $(uroot_dir)/u-root
-	echo "    MAKE       u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)"
+	@echo "    MAKE       u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)"
 ifneq ($(CONFIG_LINUXBOOT_UROOT_COMMANDS),)
 ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),)
-	cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
+	cd $(uroot_dir); \
+	GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
 	-build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio \
 	$(patsubst %,cmds/%,$(CONFIG_LINUXBOOT_UROOT_COMMANDS))
 else
-	cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
+	cd $(uroot_dir); \
+	GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
 	-build=bb -o $(project_dir)/initramfs.cpio \
 	$(patsubst %,cmds/%,$(CONFIG_LINUXBOOT_UROOT_COMMANDS))
 endif
 else
 ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),)
-	cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
+	cd $(uroot_dir); \
+	GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
 	-build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio coreboot-app
 else
-	cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
+	cd $(uroot_dir); \
+	GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \
 	-build=bb -o $(project_dir)/initramfs.cpio coreboot-app
 endif
 endif

-- 
To view, visit https://review.coreboot.org/29514
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic63a8f498720fda6d4ac3e287572dbf76500adfa
Gerrit-Change-Number: 29514
Gerrit-PatchSet: 1
Gerrit-Owner: Jens Drenhaus <jens.drenhaus at 9elements.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/a86f8005/attachment.html>


More information about the coreboot-gerrit mailing list