[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add PCIE ASL entry

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29509 )

Change subject: soc/intel/icelake: Add PCIE ASL entry
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/29509/3/src/soc/intel/icelake/acpi/pcie.asl
File src/soc/intel/icelake/acpi/pcie.asl:

https://review.coreboot.org/#/c/29509/3/src/soc/intel/icelake/acpi/pcie.asl@27
PS3, Line 27: 		Package () { 0x0000ffff, 0, 0, 11 },
            : 		Package () { 0x0000ffff, 1, 0, 10 },
            : 		Package () { 0x0000ffff, 2, 0, 11 },
            : 		Package () { 0x0000ffff, 3, 0, 11 } })
you are mapping multiple pins to the same link?
Could you explain it in the commit message as the commit message does not seem to match at all what you are doing...



-- 
To view, visit https://review.coreboot.org/29509
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9693f2a52529961e6b611b69e389f01f77f77d63
Gerrit-Change-Number: 29509
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Tue, 06 Nov 2018 13:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/d30fed4d/attachment.html>