[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Update GPIOs for Icelake SOC

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29495 )

Change subject: soc/intel/icelake: Update GPIOs for Icelake SOC
......................................................................


Patch Set 5:

(5 comments)

https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c
File src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@52
PS5, Line 52: /* TBT_CIO_PLUG_EVENT_N */	PAD_CFG_GPI_SCI(GPP_E17, NONE, DEEP, EDGE_SINGLE, NONE),
line over 80 characters


https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@56
PS5, Line 56: /* BIOS_REC */ 	PAD_CFG_GPI(GPP_F5, NONE, PLTRST),
please, no space before tabs


https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@84
PS5, Line 84: const struct cros_gpio * __attribute__((weak)) variant_cros_gpios(size_t *num)
"foo * bar" should be "foo *bar"


https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c
File src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c:

https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c@52
PS5, Line 52: /* TBT_CIO_PLUG_EVENT_N */	PAD_CFG_GPI_SCI(GPP_E17, NONE, DEEP, EDGE_SINGLE, NONE),
line over 80 characters


https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c
File src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c:

https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c@52
PS5, Line 52: /* TBT_CIO_PLUG_EVENT_N */	PAD_CFG_GPI_SCI(GPP_E17, NONE, DEEP, EDGE_SINGLE, NONE),
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I223abacc18f78631a42f340952f13d45fa9a4703
Gerrit-Change-Number: 29495
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 06 Nov 2018 06:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/6f55559d/attachment.html>