[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Update GPIOs for Icelake SOC

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Nov 6 07:33:47 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29495 )

Change subject: soc/intel/icelake: Update GPIOs for Icelake SOC
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/29495/3/src/soc/intel/icelake/include/soc/gpio_soc_defs.h
File src/soc/intel/icelake/include/soc/gpio_soc_defs.h:

https://review.coreboot.org/#/c/29495/3/src/soc/intel/icelake/include/soc/gpio_soc_defs.h@280
PS3, Line 280: #define NUM_GPIO_COM5_PADS	(GPP_S7 - GPP_R0 + 1 )
space prohibited before that close parenthesis ')'



-- 
To view, visit https://review.coreboot.org/29495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I223abacc18f78631a42f340952f13d45fa9a4703
Gerrit-Change-Number: 29495
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 06 Nov 2018 06:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/80b0c74e/attachment.html>


More information about the coreboot-gerrit mailing list