[coreboot-gerrit] Change in coreboot[master]: [wip]mb/google/sarien: Add HD Audio verb table

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Nov 5 23:47:40 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29484 )

Change subject: [wip]mb/google/sarien: Add HD Audio verb table
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29484/1/src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h
File src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h:

https://review.coreboot.org/#/c/29484/1/src/mainboard/google/sarien/variants/arcada/include/variant/hda_verb.h@64
PS1, Line 64: 	/* NID 0x20 set class-D to 2W at 4ohm (+12dB gain) + Set sine tone gain(0x34) */
line over 80 characters


https://review.coreboot.org/#/c/29484/1/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h
File src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h:

https://review.coreboot.org/#/c/29484/1/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h@52
PS1, Line 52: 	/* ALC3204 Speaker output power - 4 ohm 2W (+12dB gain)  + Combo Jack TRS setting */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29484
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icedbb510c7668d96c99c657091fc865f03bf7783
Gerrit-Change-Number: 29484
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 22:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/ae330fcb/attachment.html>


More information about the coreboot-gerrit mailing list