[coreboot-gerrit] Change in coreboot[master]: util/abuild: Use absolute paths for (failed|passed)_boards

Nico Huber (Code Review) gerrit at coreboot.org
Mon Nov 5 23:44:37 CET 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/29451 )

Change subject: util/abuild: Use absolute paths for (failed|passed)_boards
......................................................................


Patch Set 2: -Code-Review

(1 comment)

https://review.coreboot.org/#/c/29451/2/util/abuild/abuild
File util/abuild/abuild:

https://review.coreboot.org/#/c/29451/2/util/abuild/abuild@104
PS2, Line 104: }
This is the overkill version ;) a simpler version:

    case "$1" in
    /*)
            printf "%s" "$1";;
    *)
            printf "%s/%s" "$(pwd)" "$1" | sed 's,^//,/,';;
    esac

should do too. But obviously results in longer path names when
there are . or .. components.



-- 
To view, visit https://review.coreboot.org/29451
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4
Gerrit-Change-Number: 29451
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 22:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/26b2e125/attachment.html>


More information about the coreboot-gerrit mailing list