[coreboot-gerrit] Change in coreboot[master]: util/docker: Unify local build targets

Nico Huber (Code Review) gerrit at coreboot.org
Mon Nov 5 22:37:15 CET 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/29456 )

Change subject: util/docker: Unify local build targets
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29456/1/util/docker/Makefile
File util/docker/Makefile:

https://review.coreboot.org/#/c/29456/1/util/docker/Makefile@105
PS1, Line 105: override
> I don't think the override operator is needed. […]
Yes, it should be fine without. I left it to clarify that we don't
want this to be defined anywhere else...

Shall I drop it?



-- 
To view, visit https://review.coreboot.org/29456
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9088fb9211726cddc37b17ddf70170c2c382679e
Gerrit-Change-Number: 29456
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 21:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/348f498b/attachment.html>


More information about the coreboot-gerrit mailing list