[coreboot-gerrit] Change in coreboot[master]: coreboot-sdk: Don't install libisl-dev

Nico Huber (Code Review) gerrit at coreboot.org
Mon Nov 5 22:32:12 CET 2018


Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/29453 )

Change subject: coreboot-sdk: Don't install libisl-dev
......................................................................

coreboot-sdk: Don't install libisl-dev

The current version in debian:sid is incompatible with our crossgcc
version. But it turned out that we don't use the optimization features
enabled by libisl at all: crossgcc builds with and without (a proper
version of) libisl-dev installed generate the same coreboot binaries.

Change-Id: I9f9115d8ab33cbe11aa77f16c98465e1c1dedeac
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/29453
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Jonathan Neuschäfer: Looks good to me, but someone else must approve



diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile
index 4410e5b..44682f8 100644
--- a/util/docker/coreboot-sdk/Dockerfile
+++ b/util/docker/coreboot-sdk/Dockerfile
@@ -41,7 +41,6 @@
 		libftdi1-dev \
 		libglib2.0-dev \
 		libgmp-dev \
-		libisl-dev \
 		libjaylink-dev \
 		liblzma-dev \
 		libncurses5-dev \

-- 
To view, visit https://review.coreboot.org/29453
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f9115d8ab33cbe11aa77f16c98465e1c1dedeac
Gerrit-Change-Number: 29453
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/c0350081/attachment.html>


More information about the coreboot-gerrit mailing list