[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add VB2_LIB to postcar stage if available

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/29465 )

Change subject: security/vboot: Add VB2_LIB to postcar stage if available
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29465/1/src/security/vboot/Makefile.inc
File src/security/vboot/Makefile.inc:

https://review.coreboot.org/#/c/29465/1/src/security/vboot/Makefile.inc@115
PS1, Line 115: ifeq ($(CONFIG_POSTCAR_STAGE), y)
I don't think you need to guard this, actually. vboot-for-stage will just set up rules culminating up to VB2_LIB_postcar which is added to postcar-srcs. If we're not building a postcar stage, those rules just won't be executed because postcar-srcs isn't added as a dependency to anything.



-- 
To view, visit https://review.coreboot.org/29465
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I933d33b0188d1b123bb4735722b6086e7786624f
Gerrit-Change-Number: 29465
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 21:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/0c41c260/attachment.html>