[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29429 )

Change subject: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@134
PS2, Line 134: PLTRST
If you change this to PLTRST, doesn't it reset the GPIO state on entry into S3? which would prevent the device from waking the system?


https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@138
PS2, Line 138: PLTRST
So does it mean that there was some pending interrupt that wasn't getting handled by the kernel driver? And hence resetting the GPIO state prevents that interrupt from happening and hence the storm?



-- 
To view, visit https://review.coreboot.org/29429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc
Gerrit-Change-Number: 29429
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 20:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/84045ff0/attachment.html>