[coreboot-gerrit] Change in coreboot[master]: ec/kontron: Add support for Kontron kempld

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Nov 5 18:36:26 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29476 )

Change subject: ec/kontron: Add support for Kontron kempld
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29476/1/src/ec/kontron/kempld/kempld_i2c.c
File src/ec/kontron/kempld/kempld_i2c.c:

https://review.coreboot.org/#/c/29476/1/src/ec/kontron/kempld/kempld_i2c.c@169
PS1, Line 169: 			} else {
else is not generally useful after a break or return


https://review.coreboot.org/#/c/29476/1/src/ec/kontron/kempld/kempld_i2c.c@214
PS1, Line 214: 				printk(BIOS_SPEW, "kempld_i2c: Processed %zu segments.\n", num);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9a0826c4a8f5c8cd573610c2d10561334258b36
Gerrit-Change-Number: 29476
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 17:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/752ef1c5/attachment.html>


More information about the coreboot-gerrit mailing list