[coreboot-gerrit] Change in coreboot[master]: src/mainboard/portwell/m107: Do initial mainboard commit

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29470 )

Change subject: src/mainboard/portwell/m107: Do initial mainboard commit
......................................................................


Patch Set 2:

(10 comments)

https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h
File src/mainboard/portwell/m107/irqroute.h:

https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@23
PS2, Line 23: 	IR02h GFX	INT(A) 	- PIRQ A
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@25
PS2, Line 25: 	IR11h SDIO	INT(A) 	- PIRQ B
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@26
PS2, Line 26: 	IR12h SD	INT(A) 	- PIRQ C
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@27
PS2, Line 27: 	IR13h SATA	INT(A) 	- PIRQ D
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@28
PS2, Line 28: 	IR14h XHCI	INT(A) 	- PIRQ E
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@29
PS2, Line 29: 	IR15h LP Audio	INT(A) 	- PIRQ F
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@30
PS2, Line 30: 	IR17h MMC	INT(A) 	- PIRQ F
please, no space before tabs


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/irqroute.h@39
PS2, Line 39: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
File src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex:

https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@187
PS2, Line 187: 00 
trailing whitespace


https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@218
PS2, Line 218: 00 00 00 00 
trailing whitespace



-- 
To view, visit https://review.coreboot.org/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 13:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/5b9b2499/attachment.html>