[coreboot-gerrit] Change in coreboot[master]: src/mainboard/portwell/m107: Do initial mainboard commit
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Mon Nov 5 13:36:45 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29470 )
Change subject: src/mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 1:
(40 comments)
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h
File src/mainboard/portwell/m107/irqroute.h:
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@23
PS1, Line 23: *IR02h GFX INT(A) - PIRQ A
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@25
PS1, Line 25: *IR11h SDIO INT(A) - PIRQ B
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@26
PS1, Line 26: *IR12h SD INT(A) - PIRQ C
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@27
PS1, Line 27: *IR13h SATA INT(A) - PIRQ D
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@28
PS1, Line 28: *IR14h XHCI INT(A) - PIRQ E
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@29
PS1, Line 29: *IR15h LP Audio INT(A) - PIRQ F
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@30
PS1, Line 30: *IR17h MMC INT(A) - PIRQ F
please, no space before tabs
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@39
PS1, Line 39: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/irqroute.h@60
PS1, Line 60: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/romstage.c
File src/mainboard/portwell/m107/romstage.c:
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/romstage.c@30
PS1, Line 30: char buf[32];
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/romstage.c@34
PS1, Line 34: strcpy(buf, CONFIG_MAINBOARD_SPD0_FILE_NAME);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
File src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex:
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@35
PS1, Line 35: # bit7 : 0 = CRC covers bytes 0 ~ 128
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@61
PS1, Line 61: # bits[7:6]: 0 = reserved
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@80
PS1, Line 80: # bits[7:5]: reserved
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@90
PS1, Line 90: 01
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@117
PS1, Line 117: 78
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@151
PS1, Line 151: 3C
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@154
PS1, Line 154: 3C
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@168
PS1, Line 168: #
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@181
PS1, Line 181: 41
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@187
PS1, Line 187: 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@190
PS1, Line 190: 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@193
PS1, Line 193: 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@196
PS1, Line 196: 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@199
PS1, Line 199: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@203
PS1, Line 203: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@204
PS1, Line 204: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@205
PS1, Line 205: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@209
PS1, Line 209: 80 CE
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@212
PS1, Line 212: 01
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@215
PS1, Line 215: 12 1B
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@218
PS1, Line 218: 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@225
PS1, Line 225: 20 20
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@228
PS1, Line 228: 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@231
PS1, Line 231: 80 CE
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@234
PS1, Line 234: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@240
PS1, Line 240: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@241
PS1, Line 241: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@242
PS1, Line 242: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex@243
PS1, Line 243: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
--
To view, visit https://review.coreboot.org/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 12:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/4ae1b492/attachment.html>
More information about the coreboot-gerrit
mailing list