[coreboot-gerrit] Change in coreboot[master]: util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG
Nico Huber (Code Review)
gerrit at coreboot.org
Sun Nov 4 19:37:17 CET 2018
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29458
Change subject: util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG
......................................................................
util/docker: Rename _CONTAINER_VERSION => _IMAGE_TAG
This is so confusing, let's name it what it is ;)
Change-Id: I6f87e2f6912d886e241e03998fb4136fb28bc7b1
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M util/docker/Makefile
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/29458/1
diff --git a/util/docker/Makefile b/util/docker/Makefile
index eb43c98..6925b57 100644
--- a/util/docker/Makefile
+++ b/util/docker/Makefile
@@ -26,7 +26,7 @@
export COREBOOT_JENKINS_CONTAINER?=coreboot_jenkins
# Version of the jenkins / sdk container
-export COREBOOT_CONTAINER_VERSION?=$(crossgcc_version)
+export COREBOOT_IMAGE_TAG?=$(crossgcc_version)
# Commit id to build from
export DOCKER_COMMIT?=$(shell git log -n 1 --pretty=%h)
@@ -55,21 +55,21 @@
@echo "Building coreboot SDK $(crossgcc_version) from commit $(DOCKER_COMMIT)"
cat coreboot-sdk/Dockerfile | \
sed "s/{{DOCKER_COMMIT}}/$(DOCKER_COMMIT)/" | \
- sed "s/{{SDK_VERSION}}/$(COREBOOT_CONTAINER_VERSION)/" | \
+ sed "s/{{SDK_VERSION}}/$(COREBOOT_IMAGE_TAG)/" | \
sed "s/{{CROSSGCC_PARAM}}/$(COREBOOT_CROSSGCC_PARAM)/" | \
- $(DOCKER) build -t coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) -
+ $(DOCKER) build -t coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) -
upload-coreboot-sdk: test-docker-login
- $(DOCKER) push coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION)
+ $(DOCKER) push coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG)
coreboot-jenkins-node: test-docker
cat coreboot-jenkins-node/Dockerfile | \
- sed "s/{{SDK_VERSION}}/$(COREBOOT_CONTAINER_VERSION)/" | \
+ sed "s/{{SDK_VERSION}}/$(COREBOOT_IMAGE_TAG)/" | \
sed "s|{{SSH_KEY}}|$$(cat coreboot-jenkins-node/authorized_keys)|" | \
- $(DOCKER) build -t coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION) -
+ $(DOCKER) build -t coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) -
upload-coreboot-jenkins-node: test-docker-login
- $(DOCKER) push coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION)
+ $(DOCKER) push coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG)
docker-killall: test-docker
@if [ -n "$$($(DOCKER) ps | grep 'coreboot')" ]; then \
@@ -107,7 +107,7 @@
--volume $(top):/home/coreboot/coreboot \
--env HOME=/home/coreboot \
--user $(UID):$(GID) \
- coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \
+ coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \
/bin/bash -c 'cd $${HOME}/coreboot && $(DOCKER_RUN_LOCAL)'
docker-build-coreboot: docker-run-local
@@ -138,7 +138,7 @@
-p $(COREBOOT_JENKINS_PORT):49151 \
-v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache \
--name=$(COREBOOT_JENKINS_CONTAINER) \
- coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION)
+ coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG)
docker-jenkins-shell: test-docker
@if [ ! -d $(COREBOOT_JENKINS_CACHE_DIR) ]; then printf "\nError: %s does not exist.\nPlease run:\nsudo mkdir -p %s\n\n" "$(COREBOOT_JENKINS_CACHE_DIR)" "$(COREBOOT_JENKINS_CACHE_DIR)"; false; fi
@@ -148,7 +148,7 @@
-v $(top):/home/coreboot/coreboot \
-v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache \
--name=$(COREBOOT_JENKINS_CONTAINER) \
- --rm coreboot/coreboot-jenkins-node:$(COREBOOT_CONTAINER_VERSION)
+ --rm coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG)
docker-shell: USER=coreboot
docker-shell: test-docker
@@ -156,7 +156,7 @@
-e COLUMNS=$(shell tput cols) -e LINES=$(shell tput lines) -e TERM=$(TERM) \
-w /home/coreboot/coreboot \
-v $(top):/home/coreboot/coreboot \
- --rm coreboot/coreboot-sdk:$(COREBOOT_CONTAINER_VERSION) \
+ --rm coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \
/bin/bash -l
docker-jenkins-attach: USER=root
@@ -191,7 +191,7 @@
@echo " COREBOOT_JENKINS_PORT=$(COREBOOT_JENKINS_PORT)"
@echo " COREBOOT_JENKINS_CACHE_DIR=$(COREBOOT_JENKINS_CACHE_DIR)"
@echo " COREBOOT_JENKINS_CONTAINER=$(COREBOOT_JENKINS_CONTAINER)"
- @echo " COREBOOT_CONTAINER_VERSION=$(COREBOOT_CONTAINER_VERSION)"
+ @echo " COREBOOT_IMAGE_TAG=$(COREBOOT_IMAGE_TAG)"
@echo " DOCKER_COMMIT=$(DOCKER_COMMIT)"
.PHONY: test-docker test-docker-login
--
To view, visit https://review.coreboot.org/29458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f87e2f6912d886e241e03998fb4136fb28bc7b1
Gerrit-Change-Number: 29458
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/da0f0f43/attachment-0001.html>
More information about the coreboot-gerrit
mailing list