[coreboot-gerrit] Change in coreboot[master]: x86/acpi.c: Be more verbose when finding the wakeup vector

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29449 )

Change subject: x86/acpi.c: Be more verbose when finding the wakeup vector
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/29449/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29449/1//COMMIT_MSG@7
PS1, Line 7: x86/acpi.c: Be more verbose when finding the wakeup vector
> The original Git rule is 55 chars for the summary. We allow […]
Now I understand why my editor (neovim) would only highlight a part of the summary...
Done


https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:

https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282
PS1, Line 1282: BIOS_ALE
> rather BIOS_ALERT
Done


https://review.coreboot.org/#/c/29449/1/src/arch/x86/acpi.c@1282
PS1, Line 1282: 		printk(BIOS_ALERT,
> Please don't break the string literal. If you want to honor the […]
Done



-- 
To view, visit https://review.coreboot.org/29449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4
Gerrit-Change-Number: 29449
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 04 Nov 2018 16:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/9608784c/attachment.html>