[coreboot-gerrit] Change in coreboot[master]: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29447 )

Change subject: src/mb/asus/p5qc/gpio.c: Allow specifying a gpio.c in Kconfig
......................................................................


Patch Set 3:

> Patch Set 2: Code-Review-1
> 
> Please do not duplicate the file, you can point to the correct one in
> Kconfig. e.g.
> 
>     config ...
>             string
>             default "variants/p5qc/gpio.c" if PRO
>             default "variants/$(VARIANT_DIR)/gpio.c"

I made something that works and does not need to duplicate gpio.c. Not sure how sane it is, though.


-- 
To view, visit https://review.coreboot.org/29447
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f7c8c12cb1bdcf47f3b4d4cef0b11e44a5b8863
Gerrit-Change-Number: 29447
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 04 Nov 2018 15:57:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/3281fd2c/attachment.html>