[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant
Bill XIE (Code Review)
gerrit at coreboot.org
Sun Nov 4 15:34:45 CET 2018
Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................
Patch Set 6:
> Patch Set 5: Code-Review-1
>
> (1 comment)
>
> Please use an override devicetree instead. See google/fizz for example,
> `config OVERRIDE_DEVICETREE` and 27efc501d1 (util/sconfig: Add support
> for overriding base tree properties/node).
Done.
Please help review them. (they may need further changes)
--
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 04 Nov 2018 14:34:45 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/5ecdac8c/attachment.html>
More information about the coreboot-gerrit
mailing list