[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29434 )

Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

Please use an override devicetree instead. See google/fizz for example,
`config OVERRIDE_DEVICETREE` and 27efc501d1 (util/sconfig: Add support
for overriding base tree properties/node).

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb
File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@79
PS5, Line 79: 0x2005
> As far as I understand UVSCC only applies to the "upper" aka second flash chip.
The SPI Guide suggests to fill both for maximum compatibility. And
no, it's kind of the other way around. If there is no distinction,
everything is "upper".

The actual distinction is not based on the chips but a configurable
boundary (FPBA in the descriptor). Everything below that boundary
is "lower"; if FPBA is 0, nothing is below it.

They probably made it that weird to be able to treat two flash chips
with the same characteristics as one (wrt. all the lower/upper set-
tings).



-- 
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 04 Nov 2018 13:05:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/8cc2a377/attachment.html>