[coreboot-gerrit] Change in coreboot[master]: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29449


Change subject: src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector
......................................................................

src/arch/x86/acpi.c: Be more verbose when finding the wakeup vector

Since S3 resume sometimes breaks when trying to find the wakeup vector,
it is useful to log whether it errors or not. Since it is an error,
print it as such.

Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
---
M src/arch/x86/acpi.c
1 file changed, 9 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/29449/1

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 24db7c0..26789d6 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -1278,8 +1278,11 @@
 			break;
 	}
 
-	if (rsdp == NULL)
+	if (rsdp == NULL) {
+		printk(BIOS_ERR, "No RSDP found, wake up from S3 not "
+		       "possible.\n");
 		return NULL;
+	}
 
 	printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp);
 	rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address;
@@ -1294,14 +1297,17 @@
 		fadt = NULL;
 	}
 
-	if (fadt == NULL)
+	if (fadt == NULL) {
+		printk(BIOS_ERR, "No FADT found, wake up from S3 not "
+		       "possible.\n");
 		return NULL;
+	}
 
 	printk(BIOS_DEBUG, "FADT found at %p\n", fadt);
 	facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl;
 
 	if (facs == NULL) {
-		printk(BIOS_DEBUG, "No FACS found, wake up from S3 not "
+		printk(BIOS_ERR, "No FACS found, wake up from S3 not "
 		       "possible.\n");
 		return NULL;
 	}

-- 
To view, visit https://review.coreboot.org/29449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4
Gerrit-Change-Number: 29449
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/a0ffd05a/attachment.html>