[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )

Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................


Patch Set 5:

(4 comments)

@Nico: As far as I understand UVSCC applies to the second flash chip and should be set to 0 on boards that only have one flash chip, correct ?

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb
File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@71
PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0
> X1 does not have Expresscard slot.
Ack


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@79
PS5, Line 79: 0x2005
> No, it has one flash chip, same as x220.
As far as I understand UVSCC only applies to the "upper" aka second flash chip.


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@104
PS5, Line 104: on
> a wlan card slot, and a USB3 controller.
in that case you have three unused enabled pcie slots, which should be set to "off".


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@173
PS5, Line 173: has_bdc_detection
> How to check whether BDC detection works?
enable has_bdc_detection and set bdc_gpio_num=54 and test if BDC is still detected by Lenovo's H8 code. it prints "H8: BDC ..."



-- 
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 04 Nov 2018 08:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/c7c800dd/attachment.html>