[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )

Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................


Patch Set 4:

(4 comments)

https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx_series.md
File Documentation/mainboard/lenovo/t4xx_series.md:

https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx_series.md@7
PS4, Line 7: :doc:`thinkpad_hmm`
Why is this here ?
Should be mainboard/index.md


https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md
File Documentation/mainboard/lenovo/x1.md:

https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md@1
PS4, Line 1: # Lenovo X1
this file needs to be referenced from mainboard/index.md


https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md@9
PS4, Line 9: 
No picture ?


https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x2xx_series.md
File Documentation/mainboard/lenovo/x2xx_series.md:

https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x2xx_series.md@3
PS4, Line 3: A skilled engineer takes around 5 minutes to remove the keyboard and
not very detailed...



-- 
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 03 Nov 2018 15:44:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181103/66fd00ed/attachment.html>