[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add PID based on Icelake EDS

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Nov 2 14:12:37 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29436 )

Change subject: soc/intel/icelake: Add PID based on Icelake EDS
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29436/1/src/soc/intel/icelake/bootblock/pch.c
File src/soc/intel/icelake/bootblock/pch.c:

https://review.coreboot.org/#/c/29436/1/src/soc/intel/icelake/bootblock/pch.c@104
PS1, Line 104: 	if (pmc_reg_value != 0xFFFFFFFF)
that open brace { should be on the previous line



-- 
To view, visit https://review.coreboot.org/29436
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9e06f06a39dc76a3c1351d7976505d7bd92d10
Gerrit-Change-Number: 29436
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 02 Nov 2018 13:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181102/15a749c5/attachment.html>


More information about the coreboot-gerrit mailing list