[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corr...

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/29361 )

Change subject: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29361/1/src/mainboard/google/poppy/variants/nocturne/memory.c
File src/mainboard/google/poppy/variants/nocturne/memory.c:

https://review.coreboot.org/#/c/29361/1/src/mainboard/google/poppy/variants/nocturne/memory.c@36
PS1, Line 36: 30
> That is a question for Intel.  I posted this CL per their request in comment #134 on b:111812662. […]
We tested this on the failing platform and saw the improvement. We are in process of testing to other working SKU's also. Also we have asked our memory team to let us know if there can be any side effect for this change. Will update the crosbug and the patch with our findings.



-- 
To view, visit https://review.coreboot.org/29361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefc3957f915a39a47ad6018459e65b70d1b34091
Gerrit-Change-Number: 29361
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Comment-Date: Fri, 02 Nov 2018 04:50:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181102/3ab2f2a8/attachment.html>