[coreboot-gerrit] Change in coreboot[master]: src/cpu: Remove unneeded headers

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26732 )

Change subject: src/cpu: Remove unneeded headers
......................................................................


Patch Set 2:

(10 comments)

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_65x/model_65x_init.c
File src/cpu/intel/model_65x/model_65x_init.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_65x/model_65x_init.c@17
PS2, Line 17: #include <stdint.h>
not used either?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_67x/model_67x_init.c
File src/cpu/intel/model_67x/model_67x_init.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_67x/model_67x_init.c@17
PS2, Line 17: #include <console/console.h>
            : #include <string.h>
both unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_68x/model_68x_init.c
File src/cpu/intel/model_68x/model_68x_init.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_68x/model_68x_init.c@20
PS2, Line 20: #include <string.h>
unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_69x/model_69x_init.c
File src/cpu/intel/model_69x/model_69x_init.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_69x/model_69x_init.c@14
PS2, Line 14: #include <console/console.h>
unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_69x/model_69x_init.c@16
PS2, Line 16: #include <string.h>
unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6bx/model_6bx_init.c
File src/cpu/intel/model_6bx/model_6bx_init.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6bx/model_6bx_init.c@20
PS2, Line 20: #include <string.h>
unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6dx/model_6dx_init.c
File src/cpu/intel/model_6dx/model_6dx_init.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6dx/model_6dx_init.c@14
PS2, Line 14: #include <console/console.h>
unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6dx/model_6dx_init.c@16
PS2, Line 16: #include <string.h>
unused?


https://review.coreboot.org/#/c/26732/2/src/cpu/intel/slot_1/l2_cache.c
File src/cpu/intel/slot_1/l2_cache.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/intel/slot_1/l2_cache.c@43
PS2, Line 43: #include <string.h>
unused? (didn't look very close)


https://review.coreboot.org/#/c/26732/2/src/cpu/x86/tsc/delay_tsc.c
File src/cpu/x86/tsc/delay_tsc.c:

https://review.coreboot.org/#/c/26732/2/src/cpu/x86/tsc/delay_tsc.c@15
PS2, Line 15: #include <console/console.h>
unused?



-- 
To view, visit https://review.coreboot.org/26732
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fb03ada29b37f96fb02122462dfb8ec7faa9d31
Gerrit-Change-Number: 26732
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 31 May 2018 13:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180531/bfb3636d/attachment.html>