[coreboot-gerrit] Change in coreboot[master]: util/sconfig: Re-factor sconfig to not assume chip as device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26720 )

Change subject: util/sconfig: Re-factor sconfig to not assume chip as device
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.c_shipped
File util/sconfig/sconfig.tab.c_shipped:

https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.c_shipped@112
PS2, Line 112: USR_LOCAL_GOOGLE_HOME_FURQUAN_COREBOOT_
This needs to be fixed.


https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.h_shipped
File util/sconfig/sconfig.tab.h_shipped:

https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.h_shipped@33
PS2, Line 33: YY_YY_USR_LOCAL_GOOGLE_HOME_FURQUAN_COREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
this too.



-- 
To view, visit https://review.coreboot.org/26720
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I255092f527c8eecb144385eb681df20e54caf8f5
Gerrit-Change-Number: 26720
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 30 May 2018 23:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/2aef723a/attachment.html>