[coreboot-gerrit] Change in coreboot[master]: mb/google/rambi: Set SMI mask using google_chromeec_events_init

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed May 30 21:05:04 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26710


Change subject: mb/google/rambi: Set SMI mask using google_chromeec_events_init
......................................................................

mb/google/rambi: Set SMI mask using google_chromeec_events_init

This change updates rambi ec init to perform SMI mask setting using
google_chromeec_events_init.

Change-Id: I7def3c07b4d7bfbe15b2d1c45381bdc31b7e3476
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/rambi/ec.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/26710/1

diff --git a/src/mainboard/google/rambi/ec.c b/src/mainboard/google/rambi/ec.c
index 307aedf..60f3d30 100644
--- a/src/mainboard/google/rambi/ec.c
+++ b/src/mainboard/google/rambi/ec.c
@@ -25,6 +25,7 @@
 	const struct google_chromeec_event_info info = {
 		.log_events = MAINBOARD_EC_LOG_EVENTS,
 		.sci_events = MAINBOARD_EC_SCI_EVENTS,
+		.smi_events = MAINBOARD_EC_SMI_EVENTS,
 		.s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
 		.s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
 	};
@@ -34,8 +35,5 @@
 
 	google_chromeec_events_init(&info, s3_wakeup);
 
-	if (!s3_wakeup)
-		google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS);
-
 	post_code(0xf1);
 }

-- 
To view, visit https://review.coreboot.org/26710
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7def3c07b4d7bfbe15b2d1c45381bdc31b7e3476
Gerrit-Change-Number: 26710
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/8fe517c8/attachment.html>


More information about the coreboot-gerrit mailing list